php: add a dev ouptut & strip all the binaries #14822
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves files depending on build inputs to a separate output.
layus
changed the title
| @@ -37,8 +37,8 @@ in { | |||
|
|
|||
| phpPackage = mkOption { | |||
| type = types.package; | |||
| default = pkgs.php; | |||
| defaultText = "pkgs.php"; | |||
| default = pkgs.php.out; | |||
There was a problem hiding this comment.
Instead of making the user to set e.g. phpPackage = php56.out;, keep this as it is, but instead use ${phpPackage.out} everywhere where phpPackage was used by the module.
|
Other than the comment I made, looks good to me. |
dezgeg
added
0.kind: enhancement
|
Closing while we are working on #15339 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits introduce stripping to all the binaries, and create a dev output to separate php's generated include files which contain references to build inputs.
Also update nixos to pick the right output.